Merged
Conversation
Contributor
Author
|
Looks like this deprecation notice is failing the static build
Which is weird since this actually builds on 8.4 |
dunglas
reviewed
Mar 9, 2025
|
|
||
| wc.Num = v | ||
| if d.NextArg() { | ||
| // TODO: this should error in a V2 |
Member
There was a problem hiding this comment.
Why not making an error right now?
Contributor
Author
There was a problem hiding this comment.
We can if you're fine with it 👍 . It will legitimately break a lot of existing Caddyfiles though
Contributor
Author
There was a problem hiding this comment.
Alright this will error now. I tried to make the error message descriptive
withinboredom
approved these changes
Mar 9, 2025
dunglas
approved these changes
Mar 10, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been multiple issues like #1419, #1423 or #1356 (comment) where people have unknowingly wrongly configured FrankenPHP.
Ideally, it should error on wrong configuration. This PR makes it so there's at least a warning to not break current Caddy configurations.
It also allows allows this shorthand worker configuration:
ENV FRANKENPHP_CONFIG="worker ./public/index.php watch"