Skip to content

fix: timeouts handling on macOS#1435

Merged
dunglas merged 13 commits intomainfrom
ci/tests-on-mac
Mar 11, 2025
Merged

fix: timeouts handling on macOS#1435
dunglas merged 13 commits intomainfrom
ci/tests-on-mac

Conversation

@dunglas
Copy link
Copy Markdown
Member

@dunglas dunglas commented Mar 10, 2025

No description provided.

@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented Mar 11, 2025

Ok, the tests are now running but fail.

I've the same failures on my Mac locally.

@AlliBalliBaba the issue has likely be introduced by the new features we merged.

@AlliBalliBaba
Copy link
Copy Markdown
Contributor

Interesting that the ENV will behave differently on Mac, I'll have a look 👍

@AlliBalliBaba
Copy link
Copy Markdown
Contributor

AlliBalliBaba commented Mar 11, 2025

Or rather it looks like the php.ini settings are ignored on Mac. Could it be that ZEND_MAX_EXECUTION_TIMERS don't work on Mac?

@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented Mar 11, 2025

Indeed, that's that, for sure.

@AlliBalliBaba
Copy link
Copy Markdown
Contributor

Should be fine now 👍.

Maybe I'll make an experimental PR for max_execution_time from the go side since it could benefit Mac. On the other hand, it looks like timers have traded some of their performance for precision going from go 1.22 -> go 1.23.

Comment thread frankenphp.c
@dunglas dunglas changed the title ci: run tests on macOS fix: timeouts handling on macOS Mar 11, 2025
@dunglas dunglas merged commit 424ca42 into main Mar 11, 2025
55 checks passed
@dunglas dunglas deleted the ci/tests-on-mac branch March 11, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants