Skip to content

fix: ensure env is not in an invalid state on shutdown #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 3 commits into from
Mar 19, 2025
Merged

fix: ensure env is not in an invalid state on shutdown #1442

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4bbb10
ensure $_ENV is not in an invalid state before shutdown
AlliBalliBaba Mar 13, 2025
e1560e0
trigger
AlliBalliBaba Mar 13, 2025
cde8095
Resets shutdown order.
AlliBalliBaba Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frankenphp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,11 @@ static zend_module_entry frankenphp_module = {
STANDARD_MODULE_PROPERTIES};

static void frankenphp_request_shutdown() {
if (is_worker_thread) {
/* ensure $_ENV is not in an invalid state before shutdown */
zval_ptr_dtor_nogc(&PG(http_globals)[TRACK_VARS_ENV]);
array_init(&PG(http_globals)[TRACK_VARS_ENV]);
}
php_request_shutdown((void *)0);
frankenphp_free_request_context();
}
Expand Down
Loading