Merged
Conversation
pierredup
force-pushed
the
static-build-fixes
branch
from
aebd9e6 to
faa975c
Compare
dunglas
approved these changes
Apr 1, 2025
crazywhalecc
reviewed
Apr 2, 2025
| mkdir -p static-php-cli/ | ||
| cd static-php-cli/ | ||
| curl -o spc -fsSL "https://dl.static-php.dev/static-php-cli/spc-bin/nightly/spc-linux-$(uname -m)" | ||
| curl -o spc -fsSL "https://dl.static-php.dev/static-php-cli/spc-bin/nightly/spc-linux-${arch}" |
Contributor
There was a problem hiding this comment.
spc has arm binary, but it's using GNU-style arch name: aarch64, not arm64.
Contributor
Author
There was a problem hiding this comment.
I think this is still valid then. arch is set to uname -m at the top of the file, so we're just re-using the variable here. And if arch is set to arm64, then the download will fail since a binary with arm64 does not exist
Contributor
|
I just realized that the script is completely messed up for consecutive compilations. Half the variables are only set in the else block of the cache key. |
Member
|
Thanks! |
henderkes
pushed a commit
to static-php/frankenphp
that referenced
this pull request
Apr 18, 2025
* Fixes build-static script * Add composer to gnu image * Fix syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fixes for the build-static script (mostly issues when running the script multiple times)
libphpis already built,spcCommandis not set and causes error when usedstatic-php-clidirectory if it already existsSPC_REL_TYPEis set tobinarybut the arch is arm64, don't download the binary and use source instead