Skip to content

disable -march-native #1493

Merged
dunglas merged 1 commit intophp:mainfrom
crazywhalecc:no-march-native
Apr 15, 2025
Merged

disable -march-native #1493
dunglas merged 1 commit intophp:mainfrom
crazywhalecc:no-march-native

Conversation

@henderkes
Copy link
Copy Markdown
Contributor

in case that lead to the illegal instruction de265_init->init_scan_order

see #1460

@henderkes
Copy link
Copy Markdown
Contributor Author

Just had a lightbulb moment that perhaps the reason I haven't been able to reproduce these was that I don't have access to cpu architectures that wouldn't be strictly compatible with the docker images. I think this is worth a shot - if it doesn't fix the many illegal instruction issues we can add it back in.

@henderkes
Copy link
Copy Markdown
Contributor Author

As a side note, frankenphp should build fine again tomorrow, when the spc nightly binary is updated. The build failures are caused by a bug in mimalloc v2.2.3

crazywhalecc/static-php-cli@21594cd

@dunglas dunglas merged commit 66aa975 into php:main Apr 15, 2025
43 checks passed
@dunglas
Copy link
Copy Markdown
Member

dunglas commented Apr 15, 2025

Thanks

@henderkes henderkes deleted the no-march-native branch April 15, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants