Skip to content

add compile from sources fallback to unsupported OS message #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henderkes merged 3 commits into from
Oct 29, 2025
Merged

add compile from sources fallback to unsupported OS message #1939

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa18730
add compile from sources fallback to unsupported OS message
henderkes Oct 23, 2025
8b27c98
rewrite message to indicate general support, but no precompiled binaries
henderkes Oct 24, 2025
4901db8
add logs to build-static
henderkes Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ esac

if [ -z "${THE_ARCH_BIN}" ]; then
echo "❗ FrankenPHP is not supported on ${OS} and ${ARCH}"
Copy link
Copy Markdown
Member

@dunglas dunglas Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precompiled FrankenPHP binaries aren't available for... ?

Copy link
Copy Markdown
Contributor Author

@henderkes henderkes Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my first thought, but the reality is that FrankenPHP is indeed not supported outside of Linux and MacOS. They may run into unsolvable issues during compilation. I personally don't wish to maintain FrankenPHP builds outside of Linux and macOS (and Windows, if Go ever sees MSVC compatibility).

Perhaps FrankenPHP is not supported on ${OS} and ${ARCH}, but you may succeed in compiling it yourself.?

Copy link
Copy Markdown
Member

@dunglas dunglas Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do support FreeBSD too, and I would like to add support (even if not official) for most BSD systems.

Copy link
Copy Markdown
Contributor Author

@henderkes henderkes Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we support it, it's official support :P
I'll change the message then.

echo "❗ You can attempt to compile from sources by following the documentation at: https://frankenphp.dev/docs/compile/"
exit 1
fi

Expand Down
Loading