delete source/downloads after building in script, not in dockerfile#2000
Merged
delete source/downloads after building in script, not in dockerfile#2000
Conversation
henderkes
commented
Nov 19, 2025
Comment on lines
-171
to
-174
| GITHUB_TOKEN=$(cat /run/secrets/github-token) ./build-static.sh && \ | ||
| if [ -n "${BUILD_PACKAGES}" ]; then \ | ||
| ./build-packages.sh; \ | ||
| fi; \ |
Contributor
Author
There was a problem hiding this comment.
getting rid of this entirely all together in another PR
dunglas
approved these changes
Nov 20, 2025
|
|
||
| WORKDIR /usr/local/src/php | ||
| RUN git clone --branch=PHP-8.4 https://github.com/php/php-src.git . && \ | ||
| # --enable-embed is only necessary to generate libphp.so, we don't use this SAPI directly |
Contributor
Author
There was a problem hiding this comment.
Because we use libphp.so embed SAPI directly and therefore directly rely on --enable-embed.
Member
There was a problem hiding this comment.
The comment is still relevant. We don't use the embed SAPI, but we need to use this flag to build because it builds libphp as a side effect
Contributor
Author
There was a problem hiding this comment.
Suggested change
| # --enable-embed is only necessary to generate libphp.so, we don't use this SAPI directly | |
| # --enable-embed is necessary to generate libphp.so, but we don't use the SAPI directly |
|
|
||
| [*.sh] | ||
| indent_style = tab | ||
| tab_width = 2 |
Contributor
Author
There was a problem hiding this comment.
Good question, I'm happy to change it.
Member
There was a problem hiding this comment.
I've no strong opinion on this but maybe should we use the same value everywhere for consistency?
henderkes
commented
Nov 20, 2025
dunglas
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit: also adding a .editorconfig, my ides keeps turning tabs into spaces