Feature/properties diff#2822
Conversation
|
| if (isEmptyValue(key)) return <></> | ||
|
|
||
| const textValue = isCommonSection ? t(`version.${key}`) : t(key) | ||
| const isSystemDataField = breadcrumbKey === VersionCategoryName.SYSTEM_DATA |
There was a problem hiding this comment.
breadcrumbKey should be passed as an argument to renderFieldTitle, and isCommonSection can be deleted.
| @@ -1,4 +1,5 @@ | |||
| import { api } from "@sdk/api"; | |||
| import { DataProperty } from "../properties/properties-api-slice-enhanced"; | |||
There was a problem hiding this comment.
We need to remove this code ;)
| } | ||
|
|
||
| const getPropertiesData = (): IFormattedDataStructureData[] => { | ||
| return versionData.properties.map((property) => { |
There was a problem hiding this comment.
I propose to add the fallback:
if (isEmpty(versionData?.properties) || !isArray(versionData?.properties)) return []
This helps us avoid typing errors and prevent potential data mismatches.
| fieldtype, | ||
| config: property.config | ||
| } as any, | ||
| fieldValue, |
There was a problem hiding this comment.
In IFormattedDataStructureData, we have the fieldPath. Please just add fieldPath: ''.
|
@torqdev I was just thinking about the UI side: it might be worth refining it a bit further before rolling it out to production, so we can deliver a more polished experience from the start (for example, improving navigation so users can open assets/objects directly). With that in mind, perhaps we could capture this functionality in a separate follow-up task and build on top of your current implementation there. For now, would you be okay with either continuing to iterate on this PR to further refine the UI, or alternatively closing it for the moment and letting the maintenance team pick it up and build on your work in a follow-up? What do you think? |
3 participants
Properties are versioned for data objects, so included a Properties section in order to be able to see these. Made Documents/Objects/Assets be viewed as:
asset [ID: 1]as an initial pass.Related to: pimcore/studio-backend-bundle#1626