replace altitude parameter with pressure

Author: kandersolar

pvlib/spectrum/mismatch.py

@@ -713,7 +713,7 @@ def spectral_factor_jrc(airmass, clearsky_index, module_type=None,
 
 
 def spectral_factor_polo(precipitable_water, airmass_absolute, aod500, aoi,
-                         altitude, module_type=None, coefficients=None,
+                         pressure, module_type=None, coefficients=None,
                          albedo=0.2):
     """
     Estimate the spectral mismatch for BIPV application in vertical facades.
@@ -730,8 +730,8 @@ def spectral_factor_polo(precipitable_water, airmass_absolute, aod500, aoi,
     aoi : numeric
         Angle of incidence on the vertical surface.  See :term:`aoi`.
         [degrees]
-    altitude: numeric
-        altitude over sea level. [m]
+    pressure : numeric
+        Atmospheric pressure. See :term`pressure`. [Pa]
     module_type : str, optional
         One of the following PV technology strings from [1]_:
 
@@ -764,7 +764,6 @@ def spectral_factor_polo(precipitable_water, airmass_absolute, aod500, aoi,
     if module_type is not None and coefficients is not None:
         raise ValueError('Only one of `module_type` and `coefficients` should '
                          'be provided')
-    pressure = pvlib.atmosphere.alt2pres(altitude)
     f_aoi_rel = pvlib.atmosphere.get_relative_airmass(aoi,
                                                       model='kastenyoung1989')
     f_aoi = pvlib.atmosphere.get_absolute_airmass(f_aoi_rel, pressure)

tests/spectrum/test_mismatch.py

@@ -306,21 +306,21 @@ def test_spectral_factor_jrc_supplied_ambiguous():
 
 @pytest.mark.parametrize("module_type,expected", [
     ('cdte', np.array(
-        [0.991926, 0.999809, 1.01108, 0.993319, 0.956621, 0.970872])),
+        [0.992801, 1.00004 , 1.011576, 0.995003, 0.950156, 0.975665])),
     ('monosi', np.array(
-        [1.00174, 0.971769, 0.986224, 1.01661, 1.02026, 1.0106])),
+        [1.000152, 0.969588, 0.984636, 1.015405, 1.024238, 1.005061])),
     ('cigs', np.array(
-        [1.00769, 0.959666, 0.974438, 1.02861, 1.05203, 1.03117])),
+        [1.004621, 0.956719, 0.971668, 1.0254, 1.060066, 1.020196])),
     ('asi', np.array(
-        [0.982133, 1.04674, 1.04859, 0.951109, 0.865328, 0.919515])),
+        [0.986968, 1.049725, 1.051978, 0.957968, 0.842258, 0.941927])),
 ])
 def test_spectral_factor_polo(module_type, expected):
-    altitude = 500
     pws = np.array([0.96, 0.96, 1.85, 1.88, 0.66, 0.66])
     aods = np.array([0.085, 0.085, 0.16, 0.19, 0.088, 0.088])
     ams = np.array([1.34, 1.34, 2.2, 2.2, 2.6, 2.6])
     aois = np.array([46.0, 76.0, 74.0, 28.0, 24.0, 55.0])
+    pressure = np.array([101300, 101400, 100500, 101325, 80000, 120000])
     alb = np.array([0.15, 0.2, 0.3, 0.18, 0.32, 0.26])
     out = spectrum.spectral_factor_polo(
-        pws, ams, aods, aois, altitude, module_type=module_type, albedo=alb)
-    assert np.allclose(expected, out, atol=1e-8)
+        pws, ams, aods, aois, pressure, module_type=module_type, albedo=alb)
+    np.testing.assert_allclose(out, expected, atol=1e-6)