Change location.get_sun_rise_set_transit default method#2261
Closed
AdamRJensen wants to merge 1 commit intopvlib:mainfrom
Closed
Change location.get_sun_rise_set_transit default method#2261AdamRJensen wants to merge 1 commit intopvlib:mainfrom
AdamRJensen wants to merge 1 commit intopvlib:mainfrom
Conversation
Member
Author
|
Duplicate of #2410. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The default method for
pvlib.location.Location.get_sun_rise_set_transitis'pyephem'which is an external package. It seems desirable that the default is changed to ```'spa'`` given that they are equally accurate and that SPA is included internally in pvlib.