Update get_extra_radiation references#2437
Merged
kandersolar merged 19 commits intopvlib:mainfrom Apr 23, 2025
Merged
Conversation
get_extra_radiation referencesget_extra_radiation references
Member
Author
|
Ready for an initial review. A notes section with some more explanation/theory might be worth considering in future. |
AdamRJensen
approved these changes
Apr 18, 2025
Comment on lines
+91
to
+92
| .. [6] I. Reda, A. Andreas, "Solar position algorithm for solar | ||
| radiation applications" NREL Golden, USA. NREL/TP-560- 34302, 2008. |
Member
There was a problem hiding this comment.
DOI: https://doi.org/10.2172/15003974
Title has changed to include "revised"
Member
Author
There was a problem hiding this comment.
Thanks. I added revised before the year, since the official title in the quotation marks still appears to be the same title. Let me know whether you think this is correct
cwhanse
reviewed
Apr 21, 2025
cwhanse
approved these changes
Apr 21, 2025
Member
|
Thanks @RDaxini! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_extra_radiationreferences could use an update #2333Tests addedUpdates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.