Skip to content

Fix minor issue in OEDI 9068 example gallery page#2468

Merged
AdamRJensen merged 1 commit intopvlib:mainfrom
kandersolar:example-fix
Jun 4, 2025
Merged

Fix minor issue in OEDI 9068 example gallery page#2468
AdamRJensen merged 1 commit intopvlib:mainfrom
kandersolar:example-fix

Conversation

@kandersolar
Copy link
Copy Markdown
Member

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR corrects a problem where latitude and longitude are being passed to location.get_solarposition's temperature and pressure parameters:

solar_position = location.get_solarposition(psm3.index, latitude, longitude)

@kandersolar kandersolar added this to the v0.12.1 milestone Jun 4, 2025
@AdamRJensen AdamRJensen merged commit 6e6a71b into pvlib:main Jun 4, 2025
31 checks passed
@kandersolar kandersolar deleted the example-fix branch June 4, 2025 17:31
@kandersolar kandersolar restored the example-fix branch June 5, 2025 12:02
@kandersolar kandersolar deleted the example-fix branch June 5, 2025 12:02
@kandersolar kandersolar modified the milestones: v0.12.1, v0.13.0 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants