Skip to content

Change delta_t dtype to numeric#2525

Closed
AdamRJensen wants to merge 2 commits intopvlib:mainfrom
AdamRJensen:delta_t_numeric
Closed

Change delta_t dtype to numeric#2525
AdamRJensen wants to merge 2 commits intopvlib:mainfrom
AdamRJensen:delta_t_numeric

Conversation

@AdamRJensen
Copy link
Copy Markdown
Member

  • I am familiar with the contributing guidelines
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The dtype of the delta_t parameter in the solar position algorithm should be numeric as both floats, arrays, and Series can be passed.

@AdamRJensen AdamRJensen added this to the v0.13.1 milestone Aug 1, 2025
@kandersolar
Copy link
Copy Markdown
Member

I did not check, but I suspect we do not have any tests for Series delta_t in the SPA functions. With how fiddly numba can be, I think those tests are needed before we can confidently claim numeric.

@AdamRJensen AdamRJensen closed this Aug 2, 2025
@AdamRJensen AdamRJensen deleted the delta_t_numeric branch August 2, 2025 12:55
@kandersolar kandersolar removed this from the v0.13.1 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants