Add Batzelis 2017 simple nonlinear PV model#2563
Conversation
|
This PR currently adds three new functions. As they are related to each other I thought it would be helpful to review them together, but I can split the PR into smaller pieces to make it more digestible if needed. To summarize the three functions:
The third, effectively, combines the first two with Questions for reviewers:
|
|
A question about the method: does |
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Close but not exactly the same, in my testing. The latter has to be |
I think this is the right decision for pvlib because of precedent, although personally I much prefer the normalized values.
+1
+1 |
| def batzelis(photocurrent, saturation_current, resistance_series, | ||
| resistance_shunt, nNsVth): |
There was a problem hiding this comment.
@kandersolar Was adding this SDE solver to the method options in pvsystem.singlediode discussed?
There was a problem hiding this comment.
I don't think we discussed it. I'm not in favor of adding it as a method option to pvsystem.singlediode because singlediode.batzelis solves an approximation of the single diode equation, rather than the SDE itself.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.