Conversation
|
My reaction: I think adding |
|
@cwhanse, that sounds good to me. Do you suggest I close this PR and open a new one? And what would you think about adding an optional Boolean input parameter that lets you “cap” the Marion correction at 1000 W/m^2? It would default to False (following Marion 2008 if you pass k!=0), but if you set it True, it sets output equal to regular pvwatts above 1000. This prevents efficiency from climbing above STC at POA above 1000. |
|
Up to you if you want to close this PR and start fresh. The cap sounds like a good addition for the pvlib implementation. |
|
Ok, I'll close this PR and start a new one. Edit: see new PR, #2569. |
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Still has some work to do, but I thought I would share what I've started to get feedback. Tagging @kandersolar, since we briefly discussed this.