Skip to content
Merged
Changes from 2 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
05f5408
add marion's adjustment
williamhobbs Oct 7, 2025
6d7ae12
linting
williamhobbs Oct 7, 2025
40328c8
Update pvlib/pvsystem.py
williamhobbs Oct 7, 2025
a9dfb28
Update pvlib/pvsystem.py
williamhobbs Oct 7, 2025
551e722
Update pvlib/pvsystem.py
williamhobbs Oct 7, 2025
73e80d3
Update pvlib/pvsystem.py
williamhobbs Oct 7, 2025
f25b426
Update pvlib/pvsystem.py
williamhobbs Oct 7, 2025
380bb58
more suggested changes
williamhobbs Oct 7, 2025
5d31dfd
Update pvlib/pvsystem.py
williamhobbs Oct 8, 2025
ad146b5
Update pvlib/pvsystem.py
williamhobbs Oct 8, 2025
69ce5e7
Update pvlib/pvsystem.py
williamhobbs Oct 8, 2025
dc58507
cleaning up docs
williamhobbs Oct 8, 2025
0d8b0b5
Update pvlib/pvsystem.py
williamhobbs Oct 8, 2025
90b7c54
prevent negative power
williamhobbs Oct 9, 2025
1297448
Merge branch 'add_marion' of https://github.com/williamhobbs/pvlib-py…
williamhobbs Oct 9, 2025
4488e3c
fix typo in error eqn
williamhobbs Oct 9, 2025
250af5a
fix the right typo this time...
williamhobbs Oct 9, 2025
bd16ac2
reorder err eqns
williamhobbs Oct 9, 2025
f3041c2
add more detail on `cap_adjustment`
williamhobbs Oct 9, 2025
9f756bf
return same object type that was input
williamhobbs Oct 16, 2025
17f7213
fix issue with scalars
williamhobbs Oct 16, 2025
a018525
another fix
williamhobbs Oct 16, 2025
816c82a
add tests
williamhobbs Oct 16, 2025
a19b721
increase test coverage
williamhobbs Oct 17, 2025
85016fa
more test coverage
williamhobbs Oct 17, 2025
bed78f9
fix shallow copy issue
williamhobbs Oct 17, 2025
c8b5cde
Update pvlib/pvsystem.py
williamhobbs Oct 17, 2025
1f85ed2
Update pvlib/pvsystem.py
williamhobbs Oct 17, 2025
e81b450
Update pvlib/pvsystem.py
williamhobbs Oct 17, 2025
3ea68ef
update whatsnew
williamhobbs Oct 17, 2025
86ccbb1
Merge branch 'add_marion' of https://github.com/williamhobbs/pvlib-py…
williamhobbs Oct 17, 2025
158ff41
reorganize to clean it up
williamhobbs Oct 17, 2025
1e3d413
single comp path on numpy array
williamhobbs Oct 17, 2025
bdf331d
added some comments
williamhobbs Oct 17, 2025
4c3e01d
unit formatting
williamhobbs Oct 17, 2025
996092a
call keyword arguments as keyword arguments
williamhobbs Oct 20, 2025
5777613
quick fix
williamhobbs Oct 20, 2025
3c7f1e9
a few more missed keyword args
williamhobbs Oct 20, 2025
86eb06e
simplify with_k_and_cap_adjustmen
williamhobbs Oct 20, 2025
4650443
Update pvlib/pvsystem.py
williamhobbs Oct 21, 2025
c646f21
Update pvlib/pvsystem.py
williamhobbs Oct 21, 2025
f3e165e
Update pvlib/pvsystem.py
williamhobbs Oct 21, 2025
6624239
doc formatting/linting
williamhobbs Oct 21, 2025
f7904de
Merge branch 'main' into add_marion
cwhanse Nov 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 52 additions & 2 deletions pvlib/pvsystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -2878,14 +2878,36 @@ def scale_voltage_current_power(data, voltage=1, current=1):

@renamed_kwarg_warning(
"0.13.0", "g_poa_effective", "effective_irradiance")
def pvwatts_dc(effective_irradiance, temp_cell, pdc0, gamma_pdc, temp_ref=25.):
def pvwatts_dc(effective_irradiance, temp_cell, pdc0, gamma_pdc, temp_ref=25.,
k=0.0, capped_adjustment=False):
Comment thread
williamhobbs marked this conversation as resolved.
Outdated
r"""
Implements NREL's PVWatts DC power model. The PVWatts DC model [1]_ is:
Implements NREL's PVWatts (Version 5) DC power model. The PVWatts Version
5 DC model [1]_ is:
Comment thread
williamhobbs marked this conversation as resolved.
Outdated

.. math::

P_{dc} = \frac{G_{poa eff}}{1000} P_{dc0} ( 1 + \gamma_{pdc} (T_{cell} - T_{ref}))

This model has also been referred to as the power temperature coefficient
model.

This function accepts an optional irradiance adjustment factor, `k`, based
on based on [2]_. This applies a piece-wise adjustment to power based on
irradiance, where `k` is the reduction in actual power at 200 W/m^2
relative to ideal power calculated linearly from standard test conditions,
normalized to nameplate power at standard test conditions.
Comment thread
williamhobbs marked this conversation as resolved.
Outdated

.. math::

k=\frac{0.2P_{dc0}-P_{200}}{P_{dc0}}

For example, a 500 W module that produces 95 W at 200 W/m^2 (a 5% relative
reduction in efficiency) would have a value of `k` = 0.01.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include Equation from above with k, I'd place it here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my latest change. Is that what you had in mind?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that comment was not clear. I was thinking we should copy the equation for P_DC here, and show how k modifies the power. But the equation for the adjustment is not simple (the piecewise part), so I retract that thought. If someone wants to know how the adjustment works, we've provided code and the reference.

This adjustment increases relative efficiency for irradiance above 1000
W/m^2, which may not be desired. An optional input, `capped_adjustment`,
modifies the adjustment from [2]_ to only apply below 1000 W/m^2.
Comment thread
williamhobbs marked this conversation as resolved.
Outdated

Note that ``pdc0`` is also used as a symbol in
:py:func:`pvlib.inverter.pvwatts`. ``pdc0`` in this function refers to the DC
power of the modules at reference conditions. ``pdc0`` in
Expand All @@ -2909,6 +2931,11 @@ def pvwatts_dc(effective_irradiance, temp_cell, pdc0, gamma_pdc, temp_ref=25.):
temp_ref: numeric, default 25.0
Cell reference temperature. PVWatts defines it to be 25 C and
is included here for flexibility. [C]
Comment thread
williamhobbs marked this conversation as resolved.
Outdated
k: numeric, default 0.005
Comment thread
williamhobbs marked this conversation as resolved.
Outdated
Irradiance correction factor, defined in [2]_. [unitless]
modified_marion: Boolean, default False
Comment thread
williamhobbs marked this conversation as resolved.
Outdated
Optional modification to [2]_, where no adjustment is applied above
1000 W/m^2.
Comment thread
williamhobbs marked this conversation as resolved.
Outdated

Returns
-------
Expand All @@ -2920,11 +2947,34 @@ def pvwatts_dc(effective_irradiance, temp_cell, pdc0, gamma_pdc, temp_ref=25.):
.. [1] A. P. Dobos, "PVWatts Version 5 Manual"
http://pvwatts.nrel.gov/downloads/pvwattsv5.pdf
(2014).
.. [2] B. Marion, "Comparison of Predictive Models for
Photovoltaic Module Performance,"
https://doi.org/10.1109/PVSC.2008.4922586,
Comment thread
williamhobbs marked this conversation as resolved.
Outdated
https://docs.nrel.gov/docs/fy08osti/42511.pdf
(2008).
""" # noqa: E501

pdc = (effective_irradiance * 0.001 * pdc0 *
(1 + gamma_pdc * (temp_cell - temp_ref)))

# apply Marion's correction if k is anything but zero
if k != 0:
Comment thread
williamhobbs marked this conversation as resolved.
Outdated
err_1 = (k * (1 - (1 - effective_irradiance / 200)**4) /
(effective_irradiance / 1000))
err_2 = (k * (1000 - effective_irradiance) / (1000 - 200))

pdc_marion = np.where(effective_irradiance <= 200,
Comment thread
wholmgren marked this conversation as resolved.
Outdated
pdc * (1 - err_1),
pdc * (1 - err_2))

# "cap" Marion's correction at 1000 W/m^2
if capped_adjustment is True:
pdc_marion = np.where(effective_irradiance >= 1000,
pdc,
pdc_marion)

pdc = pdc_marion

return pdc


Expand Down