Refactor variable names for clarity in APE example#2578
Merged
kandersolar merged 1 commit intomainfrom Oct 22, 2025
Merged
Conversation
kandersolar
approved these changes
Oct 21, 2025
Member
kandersolar
left a comment
There was a problem hiding this comment.
Those names were copied from plot_spectrl2_fig51A.py. I was going to suggest that we change them there too, but I think it makes more sense to keep them there since it is tied to the SPECTRL2 report, whereas this example doesn't have that context.
echedey-ls
approved these changes
Oct 21, 2025
Member
I agree with you. You can also put AKA comments or link to |
cwhanse
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remote-data) and Milestone are assigned to the Pull Request and linked Issue.I used the APE gallery example for teaching, and students found it confusing that the variable names were inconsistent with the inputs, so I suggest changing it.