Merged
Conversation
Add tests to ensure parameter name is documented as 'atmos_refract' (not 'atmos_refrac') in spa_python and solar_position docstrings. Related to pvlib#2532
Correct parameter name from 'atmos_refrac' to 'atmos_refract' in docstrings for solarposition.spa_python and spa.solar_position to match the actual function signatures. Update whatsnew to describe this change. Closes pvlib#2532
This reverts commit 452876d.
This reverts commit 216db9e.
cwhanse
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
atmos_refracttypo inpvlib.solarposition.spa_pythonandpvlib.spa.solar_position.pvlib.solarposition.spa_pythonparameteratmos_refractdocumentation has a typo #2532[ ] Tests addednot added as little value for docstring changes[ ] Updates entries innot impacteddocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.N/Aremote-data) and Milestone are assigned to the Pull Request and linked Issue.