-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add simple_efficiency tests for numpy array inputs #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kandersolar
merged 7 commits into
pvlib:main
from
aman-coder03:test-simple-efficiency-vectorized
Feb 11, 2026
+39
−27
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1ce6fe8
Add simple_efficiency tests for numpy array inputs
aman-coder03 7abb5e7
fix flake
aman-coder03 74158a2
Merge branch 'main' into test-simple-efficiency-vectorized
aman-coder03 d648e80
flake8 fix after resolving conflicts
aman-coder03 5105dfb
removing test_simple_efficiency_numpy_array_inputs
aman-coder03 56b68ac
add whatsnew entry for simple_efficiency vectorization test
aman-coder03 327066d
addressing review comments
aman-coder03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aman-coder03 I think it is premature to test with all inputs as np.array. In other discussions we don't have consensus to allow the parameters
no_load_lossandload_lossto be anything other thanfloat, and intend to edit the docstring accordingly.If we agree in the future to allow vectors for these parameters, then this test would be needed.
I don't want to include it now so to prevent someone's AI from deciding we have missed a combination of types in other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you prefer that I remove the test that uses array inputs for
no_load_lossandload_loss, and keep only the vectorizedinput_powercase? Or should I drop the vectorized tests entirely for now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think drop
test_simple_efficiency_numpy_array_inputsand keeptest_simple_efficiency_vector_equals_scalarThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implemented the suggested changes @cwhanse , thanks for your guidance!!