Integrate pytest-remaster into functional test suite#10961
Open
mchris86 wants to merge 3 commits intopylint-dev:pytest-remasterfrom
Open
Integrate pytest-remaster into functional test suite#10961mchris86 wants to merge 3 commits intopylint-dev:pytest-remasterfrom
mchris86 wants to merge 3 commits intopylint-dev:pytest-remasterfrom
Conversation
- stop asserting expected message counts in check_messages() - add expected_output_base property to test_file - use golden_master.check() in test_functional.py with version/platform dimensions - add pytest-remaster to test requirements
…th pytest-remaster integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR moves functional tests to
pytest-remaster, making expected output handling simpler and easier to update.Builds on #10953
Changes made
check_messages()inLintModuleTestexpected_output_baseproperty toFunctionalTestFilegolden_master.check()in test_functional.py with version/platform dimensionspytest-remasterto test requirementstest_lint_module_output_update.pyas it is no longer neededNote: I have kept this PR focused on integrating pytest-remaster. Happy to include cleanup of unused code and new expected output files here, or in a follow-up PR if preferred.