Conversation
Member
|
Sweet, I like the idea 👍 |
Member
|
RE: degradation, know that the benchmark might have a flawed design. It's an atypical insertion pattern. Retrieval is typically much more common than insertion. Could be an option to have a switchable implementation where different read/write performance balance is desired. |
3a8218a to
64a6ce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a set rather than object for the final layer of the index.
Short term performance gain from being able to use built-in set operations.
Long term gain from being able to use symbols for indicies
First tests seem to indicate a performance degredation
main
This branch