[VQueues] Introduce sys_vqueue_meta datafusion table#4580
Closed
AhmedSoliman wants to merge 2 commits intomainfrom
Closed
[VQueues] Introduce sys_vqueue_meta datafusion table#4580AhmedSoliman wants to merge 2 commits intomainfrom
AhmedSoliman wants to merge 2 commits intomainfrom
Conversation
This was referenced Apr 9, 2026
Closed
Test Results 8 files + 3 8 suites +3 7m 22s ⏱️ + 3m 47s Results for commit fd09f48. ± Comparison against base commit 6d70da2. This pull request removes 25 and adds 51 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This was referenced Apr 13, 2026
Merged
AhmedSoliman
force-pushed
the
pr4580
branch
4 times, most recently
from
79b4801 to
2a11280
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a11280b6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AhmedSoliman
force-pushed
the
pr4580
branch
8 times, most recently
from
58d66f0 to
f91661b
Compare
AhmedSoliman
force-pushed
the
pr4580
branch
2 times, most recently
from
a92c7df to
ec1d245
Compare
AhmedSoliman
force-pushed
the
pr4580
branch
2 times, most recently
from
bdadbec to
99567cb
Compare
AhmedSoliman
force-pushed
the
pr4580
branch
2 times, most recently
from
747b840 to
d28d838
Compare
This was referenced Apr 21, 2026
AhmedSoliman
force-pushed
the
pr4580
branch
3 times, most recently
from
b0b9244 to
f0a86b6
Compare
AhmedSoliman
changed the title
Adds a new partitioned datafusion table that exposes VQueue metadata for observability and debugging. The table surfaces per-vqueue fields from VQueueMeta: identity (id, service_name, scope, limit_key, lock_name), lifecycle flags (is_active, queue_is_paused), lifecycle timestamps (created_at, last_enqueued_at, last_start_at, last_attempt_at, last_finish_at), EMA durations (queue/inbox/run/suspension/end_to_end), and entry counts per state (inbox/running/suspended/paused/finished). A new ScanVQueueMetaTable trait is added in storage-api and implemented on PartitionStore, scanning the meta column family at Priority::Low. Decoding uses VQueueMetaRef via bilrost decode_borrowed so string columns are read zero-copy from the iterator buffer.
tillrohrmann
approved these changes
Apr 24, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Great to see your vision for introspection and observability of the new vqueues component coming together :-) LGTM. +1 for merging.
Contributor
Author
|
@tillrohrmann this was superseded by #4633. Sorry for the confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new partitioned datafusion table that exposes VQueue metadata for
observability and debugging.
The table surfaces per-vqueue fields from VQueueMeta: identity (id,
service_name, scope, limit_key, lock_name), lifecycle flags (is_active,
queue_is_paused), lifecycle timestamps (created_at, last_enqueued_at,
last_start_at, last_attempt_at, last_finish_at), EMA durations
(queue/inbox/run/suspension/end_to_end), and entry counts per state
(inbox/running/suspended/paused/finished).
A new ScanVQueueMetaTable trait is added in storage-api and implemented
on PartitionStore, scanning the meta column family at Priority::Low.
Decoding uses VQueueMetaRef via bilrost decode_borrowed so string
columns are read zero-copy from the iterator buffer.
Stack created with Sapling. Best reviewed with ReviewStack.