feat: add showValueText prop to control value text display#10
Open
Lanioque wants to merge 1 commit intornheroes:mainfrom
Open
feat: add showValueText prop to control value text display#10Lanioque wants to merge 1 commit intornheroes:mainfrom
Lanioque wants to merge 1 commit intornheroes:mainfrom
Conversation
- Add showValueText prop (default: true) to RulerPickerProps interface - Conditionally render value text display based on showValueText prop - Update value callback to only update text input when showValueText is true - Adjust indicator positioning when value text is hidden - Update example app to demonstrate both with and without value text - Update README with new prop documentation and usage examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Add showValueText Prop
This PR adds a new showValueText prop to the RulerPicker component that allows developers to control whether the value text display (number + unit) is shown above the ruler indicator.
What's New:
Changes Made:
Usage Examples:
\\jsx
// Default behavior (shows value text)
// Hide value text
\\
Testing:
This enhancement provides more flexibility for developers who want to use the ruler picker without the built-in value display, allowing them to implement their own custom value display logic.