[v640] Backport recent fixes to the release branch#22125
Merged
guitargeek merged 3 commits intoroot-project:v6-40-00-patchesfrom May 3, 2026
Merged
[v640] Backport recent fixes to the release branch#22125guitargeek merged 3 commits intoroot-project:v6-40-00-patchesfrom
guitargeek merged 3 commits intoroot-project:v6-40-00-patchesfrom
Conversation
(cherry picked from commit 42b033d)
Updated description of the Modified Anderson-Bjork root-finding algorithm to include proper citation. (cherry picked from commit a1ae51b)
In `ROperator_Conv.hxx` line 202, the `+1` in the conv output formula `(input + pad - kernel) / stride + 1` was being string-concatenated onto the stride value instead of added separately, generating `((W+-3)/21)` for stride=2 instead of the correct `((W+-3)/2+1)`. simple fix is to change the: `std::to_string(stride) + "1)";` to `+ std::to_string(stride) + "+1)";` (cherry picked from commit 00cc11d)
Test Results 22 files 22 suites 3d 9h 52m 33s ⏱️ For more details on these failures, see this check. Results for commit 4dc53f2. |
guitargeek
merged commit d892c73
into
root-project:v6-40-00-patches
29 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.