Skip to content

chore: remove eslint and commitlint #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Mar 14, 2026
Merged

chore: remove eslint and commitlint #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ permissions:

jobs:
lint:
name: Lint - ${{ matrix.os }} - Node v${{ matrix.node-version }}
name: Checks - ${{ matrix.os }} - Node v${{ matrix.node-version }}

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -32,8 +32,6 @@ jobs:
cancel-in-progress: true
steps:
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Install Pnpm
run: |
Expand All @@ -49,7 +47,7 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Lint
- name: Run checks
run: pnpm run lint

- name: Build types
Expand All @@ -58,10 +56,6 @@ jobs:
- name: Check types
run: if [ -n "$(git status types --porcelain)" ]; then echo "Missing types. Update types by running 'pnpm run build:types'"; exit 1; else echo "All types are valid"; fi

- name: Validate PR commits with commitlint
if: github.event_name == 'pull_request'
run: pnpm exec commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose

test:
name: Test - ${{ matrix.os }} - Node v${{ matrix.node-version }}

Expand Down
1 change: 0 additions & 1 deletion .husky/commit-msg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .husky/pre-commit
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions commitlint.config.js
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions eslint.config.mjs
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions lint-staged.config.js
View file
Open in desktop

This file was deleted.

13 changes: 2 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,12 @@
"types"
],
"scripts": {
"commitlint": "commitlint --from=main",
"lint:prettier": "prettier --cache --list-different .",
"lint:code": "eslint --cache .",
"lint:spelling": "cspell --cache --no-must-find-files --quiet \"**/*.*\"",
"lint:types": "tsc --pretty --noEmit",
"lint": "npm-run-all -l -p \"lint:**\"",
"fix:js": "pnpm run lint:code -- --fix",
"fix:prettier": "pnpm run lint:prettier -- --write",
"fix": "npm-run-all -l fix:js fix:prettier",
"fix": "pnpm run fix:prettier",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity and to reduce indirection, you could define the fix script directly with the prettier command instead of aliasing fix:prettier. This makes the script's action immediately obvious. You could then also consider removing the now-redundant fix:prettier script.

Suggested change
"fix": "pnpm run fix:prettier",
"fix": "pnpm run lint:prettier -- --write",

"clean": "del-cli dist types",
"build:types": "tsc --declaration --emitDeclarationOnly --outDir types && prettier \"types/**/*.ts\" --write",
"build:code": "babel src -d dist --copy-files",
Expand All @@ -42,7 +39,7 @@
"test:coverage": "pnpm run test:only -- --collectCoverageFrom=\"src/**/*.js\" --coverage",
"pretest": "pnpm run lint",
"test": "pnpm run test:coverage",
"prepare": "husky && pnpm run build",
"prepare": "pnpm run build",
"release": "standard-version"
},
"dependencies": {
Expand All @@ -56,8 +53,6 @@
"@babel/cli": "^7.16.7",
"@babel/core": "^7.16.7",
"@babel/preset-env": "^7.16.7",
"@commitlint/cli": "^20.2.0",
"@commitlint/config-conventional": "^20.2.0",
"@fastify/express": "^4.0.2",
"@hapi/hapi": "^21.3.7",
"@hono/node-server": "^1.12.0",
Expand All @@ -71,19 +66,15 @@
"cspell": "^9.6.2",
"deepmerge": "^4.2.2",
"del-cli": "^6.0.0",
"eslint": "^9.28.0",
"eslint-config-webpack": "^4.5.0",
"execa": "^5.1.1",
"express-4": "npm:express@^4",
"express": "^5.1.0",
"fastify": "^5.2.1",
"file-loader": "^6.2.0",
"finalhandler": "^2.1.0",
"hono": "^4.4.13",
"husky": "^9.1.3",
"jest": "^30.1.3",
"koa": "^3.0.0",
"lint-staged": "^16.2.7",
"npm-run-all": "^4.1.5",
"prettier": "^3.6.0",
"router": "^2.2.0",
Expand Down
Loading
Loading