perf: disable cacheImmutable by default#39
Merged
chenjiahan merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Disables cacheImmutable by default so immutable assets no longer automatically receive Cache-Control: ..., immutable unless explicitly opted in, reducing overhead on the request path.
Changes:
- Change middleware cache header behavior to only apply immutable caching when
cacheImmutable === true. - Update docs and type definitions to reflect the new default (
falsewhen omitted). - Adjust middleware tests to explicitly set
cacheImmutable: truewhere the immutable behavior is expected.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/middleware.js |
Changes immutable cache decision logic to require an explicit cacheImmutable: true. |
test/middleware.test.js |
Updates tests to opt into immutable caching explicitly and updates expectations for the new default. |
README.md |
Documents the new cacheImmutable default and updated semantics. |
src/index.js |
Updates JSDoc option docs for cacheImmutable default. |
types/index.d.ts |
Updates type docs/comments for cacheImmutable default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable cacheImmutable by default to reduce the perf overhead of
getAsset().#38