feat!: remove spdy support

[chenjiahan]

Removes spdy support, motivation:

• node-spdy has known compatibility problems on newer Node.js versions
• This aligns with the direction already taken in webpack-dev-server PR #5635, which removed spdy support

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on deprecating and removing SPDY support from the project. The motivation stems from known compatibility issues with node-spdy on newer Node.js versions and aligns with similar decisions made in related projects like webpack-dev-server. The change simplifies the codebase by eliminating an outdated dependency and its associated configuration and testing overhead, ensuring better maintainability and compatibility with modern web technologies.

Highlights

• SPDY Support Removal: The spdy dependency and all related code, configurations, and tests have been completely removed from the project. This includes its presence in package.json, pnpm-lock.yaml, server configuration logic, and test suites.
• Dependency Cleanup: The pnpm-lock.yaml file has been updated to reflect the removal of spdy and its numerous transitive dependencies, leading to a leaner dependency tree.
• Server Configuration Simplification: The server configuration logic in src/server.ts and type definitions in src/types.ts have been simplified by removing spdy-specific options and server types.
• Test Suite Refinement: All e2e tests and snapshots related to spdy server configurations have been removed, streamlining the test suite and removing deprecated test cases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• package.json
  • Removed the spdy dependency.
• pnpm-lock.yaml
  • Removed spdy and spdy-transport packages and their associated transitive dependencies from the lockfile.
• src/server.ts
  • Removed conditional logic that configured spdy server options.
• src/types.ts
  • Removed spdy specific properties from the ServerOptions type.
  • Removed 'spdy' from the ServerType union type.
• tests/e2e/snapshots/app.test.js.snap
  • Removed snapshots related to spdy server type tests.
• tests/e2e/snapshots/server.test.js.snap
  • Removed snapshots related to spdy server type tests.
• tests/e2e/app.test.js
  • Removed spdy server type from test configurations.
  • Removed spdy condition from the HTTP version check in tests.
• tests/e2e/server.test.js
  • Removed the spdy import statement.
  • Removed the entire test suite dedicated to spdy server functionality.
• tests/e2e/web-socket-server-url.test.js
  • Removed the test suite for spdy server type with web socket server URLs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

Removes built-in SPDY server support from @rspack/dev-server, aligning with upstream direction (webpack-dev-server) and avoiding known incompatibilities of node-spdy on newer Node.js versions.

Changes:

• Removed spdy as a supported server type in public TypeScript types and server-option normalization.
• Deleted E2E coverage and snapshots that exercised server: 'spdy' and related SPDY behaviors.
• Dropped the spdy dependency from package.json and updated pnpm-lock.yaml accordingly.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/e2e/web-socket-server-url.test.js	Removes SPDY-specific websocket URL E2E coverage.
tests/e2e/server.test.js	Removes SPDY server-mode E2E tests and related setup (including spdy import/spy).
tests/e2e/app.test.js	Removes SPDY variants from app-matrix tests and updates protocol assertion logic accordingly.
tests/e2e/snapshots/server.test.js.snap	Removes snapshots for deleted SPDY server tests.
tests/e2e/snapshots/app.test.js.snap	Removes snapshots for deleted SPDY app-matrix cases.
src/types.ts	Removes spdy from ServerType union and removes SPDY-specific fields from ServerOptions.
src/server.ts	Removes SPDY-specific defaulting/normalization logic.
pnpm-lock.yaml	Removes spdy and its transitive dependencies from the lockfile.
package.json	Removes spdy dependency.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request effectively removes support for spdy, which is a sensible decision due to its known compatibility issues and to maintain alignment with webpack-dev-server. The changes are thorough, covering the removal of the dependency, all related logic in the source code, and the corresponding tests and snapshots. The implementation is clean and complete. I have no further suggestions for improvement.