Conversation
There are comments here motivating the choice of 20.04 as being an older (= more compatible) glibc. It is unclear whether that is a current or vestigial requirement.
cpu
approved these changes
Apr 16, 2025
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
It is unclear whether that is a current or vestigial requirement. (Thoughts @cpu ?)
It's generally something that still applies in the sense that building on 22.04 will produce binaries with a higher minimum supported glibc than doing the same on 20.04.
IIRC I was just trying to make the release binaries as flexible as possible where it was convenient, and it wasn't something informed by deep research into the glibc version distribution in the wild or anything.
With that in mind it feels reasonable to me to follow the LTS deprecation that the runners are going through. If someone desperately needs support for older glibc they can always build from source.
| powershell -Command "Expand-Archive -Path cargo-c-windows-msvc.zip -DestinationPath $env:USERPROFILE\\.cargo\\bin -Force" | ||
|
|
||
| - name: Build rusts-ffi | ||
| - name: Build rustls-ffi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are comments here motivating the choice of 20.04 as being
an older (= more compatible) glibc. It is unclear whether that
is a current or vestigial requirement. (Thoughts @cpu ?)
If it's a current requirement, we can instead continue to build on ubuntu-20.04
by using docker hosted on ubuntu-latest.