rustls 0.23.25 -> 0.23.27#566
Merged
cpu merged 8 commits intorustls:mainfrom May 7, 2025
Merged
Conversation
djc
approved these changes
May 7, 2025
ctz
approved these changes
May 7, 2025
Simplify language a bit, use more backticks, describe success condition up-front.
In `rustls_client_connection_new` we're using the pattern of constructing a `&mut *mut` out reference from a `*mut *mut` pointer input using the `try_mut_from_ptr_ptr!` macro, which checks that the param isn't `NULL`. This means an earlier explicit check isn't needed and can be removed for clarity.
This allows constructing a client `rustls_connection` with custom ALPN protocol support that differs from the base `rustls_client_config`.
Handle the new upstream `CertificateError::InvalidPurposeContext` error type as `CertInvalidPurpose`.
Matches the change upstream in rustls 0.23.27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rustls 0.23.26 release didn't add any interesting API surface, but the 0.23.27 release did make some changes that are worth updates here:
rustls_client_connection_new_alpn()function is added to match the newClientConnection::new_with_alpn()fn.map_invalid_certificate_error()fn is updated to handle the newCertificateError::InvalidPurposeContexterror.prefer-post-quantumfeature flag is promoted to enabled-by-default to match the upstream Rustls change.