Skip to content

Added feature: SSL_group_to_name entrypoint#104

Merged
ctz merged 1 commit intorustls:mainfrom
kraemv:feature/named_groups
Jan 22, 2026
Merged

Added feature: SSL_group_to_name entrypoint#104
ctz merged 1 commit intorustls:mainfrom
kraemv:feature/named_groups

Conversation

@kraemv
Copy link
Copy Markdown
Contributor

@kraemv kraemv commented Nov 4, 2025

Hello everyone,
I added the SSL_group_to_name entrypoint, as this is required by Debian 12 nginx.

The main changes are:

In future the groups could be used to implement the functions in https://docs.openssl.org/3.3/man3/SSL_CTX_set1_curves/.

I am happy to discuss the changes!

@kraemv kraemv marked this pull request as ready for review November 4, 2025 11:44
@ctz
Copy link
Copy Markdown
Member

ctz commented Nov 4, 2025

Thanks -- could you:

  • rebase this against current main
  • squash the two commits

That should make some of the unrelated changes fall away. With that said I think the changes here are substantially good.

@kraemv kraemv force-pushed the feature/named_groups branch from 21e2e5d to 3aa196b Compare November 4, 2025 16:32
@djc
Copy link
Copy Markdown
Member

djc commented Nov 4, 2025

The rebase doesn't seem to have worked out? There's a still a bunch of other changes appearing in your commit.

@kraemv kraemv force-pushed the feature/named_groups branch from 3aa196b to c4d7585 Compare November 4, 2025 17:46
@kraemv
Copy link
Copy Markdown
Contributor Author

kraemv commented Nov 4, 2025

Sorry for the troubles! Now everything should be rebased properly.

Copy link
Copy Markdown
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback

Comment thread src/entry.rs Outdated
Comment thread src/entry.rs
Comment thread src/lib.rs Outdated
Comment thread src/lib.rs Outdated
Comment thread src/lib.rs Outdated
Comment thread src/lib.rs
Comment thread src/entry.rs
@kraemv kraemv force-pushed the feature/named_groups branch 2 times, most recently from 715b6da to 6343a4a Compare November 10, 2025 16:51
@kraemv kraemv requested a review from cpu January 21, 2026 09:44
Copy link
Copy Markdown
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, this one fell off my radar.

This looks good to me mod some final feedback. @ctz Can you do a pass & merge if you like it? 🙇

Comment thread src/constants.rs Outdated
Comment thread src/lib.rs Outdated
Comment thread src/lib.rs Outdated
Comment thread tests/constants.c
Comment thread tests/constants.c Outdated
@cpu
Copy link
Copy Markdown
Member

cpu commented Jan 21, 2026

squash the two commits

I think this would still be helpful to do as well.

@kraemv kraemv force-pushed the feature/named_groups branch from 6343a4a to dd3461b Compare January 21, 2026 15:13
Comment thread src/constants.rs
Comment thread tests/constants.c Outdated
Added: New Entrypoint to build
Added: New NIDs
Added: Test group_to_name in tests/constants.c
@kraemv kraemv force-pushed the feature/named_groups branch from dd3461b to c86df80 Compare January 21, 2026 15:38
@ctz
Copy link
Copy Markdown
Member

ctz commented Jan 22, 2026

Thanks!

@ctz ctz merged commit 515f1bc into rustls:main Jan 22, 2026
17 checks passed
@kraemv kraemv deleted the feature/named_groups branch February 2, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants