ci: use binary nfpm releases#60
Merged
cpu merged 1 commit intorustls:mainfrom Mar 30, 2025
Merged
Conversation
This removes the need to care about the installed Go version. Presently trying to build `nfpm@latest` from source fails because 2.42+ requires Go 1.23+ and we have Go 1.22 in the packager images. Rather than pin to 2.41 let's install the upstream rpm/deb since it's faster.
cpu
commented
Mar 29, 2025
Comment on lines
-212
to
-214
| # nb. ubuntu:22.04 has a too-old golang to build nfpm | ||
| # we could install an upstream golang if we want to | ||
| # package there. |
Member
Author
There was a problem hiding this comment.
I removed this comment because it doesn't apply anymore now that we're installing nfpm from releases and not src.
I didn't add a 22.04 container because it felt like the value is pretty minimal. WDYT?
djc
approved these changes
Mar 29, 2025
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Looks okay to me (but this is definitely outside my comfort zone).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.42 release stream of
nfpmrequires Go 1.23+ and the base images we're using are shipping Go 1.22. Rather than pin thego installto an older version, let's switch to using the binary releases from upstream. This is faster, and removes the need to care about Go version on the builder images.Fixes packaging task build failures observed on
main.