Bump React on Rails and Shakapacker to latest releases#701
Conversation
Align the tutorial app with the latest published React on Rails and Shakapacker packages so CI validates against the current dependency set and picks up recent upstream fixes.
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughDependency version bumps and registry configuration: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR performs a straightforward dual-stack version bump: the Key observations:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Gemfile / package.json] -->|declares| B[react_on_rails 16.4.0.rc.9\nreact-on-rails 16.4.0-rc.9]
A -->|declares| C[shakapacker 9.6.1]
B -->|requires| C
C -->|requires| D[semantic_range >= 2.3.0\nresolved: 3.1.1]
B -->|resolved in| E[Gemfile.lock]
C -->|resolved in| E
B -->|resolved in| F[yarn.lock\nregistry.yarnpkg.com]
C -->|resolved in| F
style B fill:#f0f4ff,stroke:#4a6cf7
style C fill:#f0f4ff,stroke:#4a6cf7
style D fill:#fff8e1,stroke:#f9a825
Last reviewed commit: 9574cea |
PR Review: Bump React on Rails and Shakapacker to latest releasesOverall this is a clean, focused dependency bump with no application code changes. A few observations: RC versionsBoth Transitive dependency
CI not run locallyThe PR description calls out that tests weren't run locally. CI checks are in progress — merging should be gated on those passing. Minor: yarn registry URL inconsistencyThe two bumped npm packages now reference |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Gemfile`:
- Around line 8-9: Update the Gemfile to point to an existing react_on_rails
prerelease (replace "react_on_rails", "16.4.0.rc.9" with the latest published
prerelease, e.g., "16.4.0.rc.7") so bundle install succeeds, and before
upgrading remove or migrate the deprecated generated_assets_dir key from the
react_on_rails.rb initializer: delete generated_assets_dir and instead set
Shakapacker's public_output_path in shakapacker.yml (or align existing
shakapacker.yml public_output_path to the same output directory) while leaving
supported keys (auto_load_bundle, server_bundle_js_file,
server_bundle_output_path, prerender, rendering_extension) unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b4ab8809-60a6-4ad6-a5ba-e133df0c08b0
⛔ Files ignored due to path filters (2)
Gemfile.lockis excluded by!**/*.lockyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
Gemfilepackage.json
Keep lockfile updates aligned with the repo's existing npmjs.org pattern by pinning the repo-local Yarn registry to npm's host and normalizing the two regenerated yarn.lock entries.
PR Review: Bump React on Rails and ShakapackerThis is a straightforward dependency bump PR. The changes are well-scoped and lock files have been regenerated. A few observations worth discussing: RC Versions Still in Use Both react_on_rails (16.4.0.rc.9) and react-on-rails (16.4.0-rc.9) are still pinned to release candidates. The project was already on RC versions, so this continues an existing pattern. Pinning to specific RC versions is the right call, but it is worth having a plan to migrate to stable 16.4.0 once it is released rather than continuing to track RCs long-term. Unexplained .yarnrc Addition A new .yarnrc file is added containing: registry "https://registry.npmjs.org". The PR description does not explain why this file is needed now. Was it added to resolve a registry resolution issue during the bump? Could it conflict with any CI or internal mirror configuration? If it was intentionally added to ensure correct resolution of the new package versions, that context belongs in the PR description. Tests Not Run Locally The PR description notes: did not run tests locally; CI can validate the bump. This is a low-risk stance for a dependency bump, but CI status should be confirmed before merging. Minor: Transitive Dependency semantic_range bumped from 3.1.0 to 3.1.1 as a transitive dependency of shakapacker. This appears to be a patch release and is not a concern. Verdict The version bumps look correct and the lock files appear consistently updated. The main open question is the unexplained .yarnrc addition. Please clarify its purpose before merging. |
The registry host drift came from local Yarn configuration rather than a repo requirement. Keep the lockfile normalized to npmjs.org while moving the registry setting to user-level Yarn config instead of committing a project override.
|
PR Review: Dependency Version Bumps Summary: straightforward version bump across four files. Version strings are consistent between Gemfile/Gemfile.lock and package.json/yarn.lock. Observations:
Verdict: Changes look correct and low-risk. Approve once CI is green. |
|
✅ Review app for PR #701 was successfully deleted |
Summary
react_on_railsfrom16.3.0.rc.2to16.4.0.rc.9react-on-railsfrom16.3.0-rc.2to16.4.0-rc.9shakapackergem/npm from9.5.0to9.6.1Gemfile.lockandyarn.lockNotes
Summary by CodeRabbit