Upgrade React on Rails and ShakaPacker to RC builds#710
Conversation
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughThis PR updates two frontend integration dependencies to their release candidate versions— Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR bumps
Confidence Score: 4/5Not safe to merge until the missing generated server bundle is committed or the generate_packs task is run as part of this PR. The dependency version bumps themselves are clean, but the PR description explicitly confirms the build is broken due to a missing generated file. This is a P1 blocker that prevents the repo from building correctly after merge. Gemfile — the missing client/app/packs/../generated/server-bundle-generated.js (produced by rake react_on_rails:generate_packs) must be committed or the rake task must run in CI before this is mergeable. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[master branch] -->|PR #710| B[Upgrade RC builds]
B --> C[react_on_rails 16.4.0 → 16.6.0-rc.0]
B --> D[shakapacker 9.7.0 → 10.0.0-rc.0]
C --> E[Gemfile + Gemfile.lock]
C --> F[package.json + yarn.lock]
D --> E
D --> F
E --> G{Build status}
F --> G
G -->|Missing generated file| H["❌ Module not found:\nserver-bundle-generated.js"]
G -->|Required step| I["rake react_on_rails:generate_packs"]
I --> J["✅ Build succeeds"]
Reviews (1): Last reviewed commit: "Update React on Rails and ShakaPacker RC..." | Re-trigger Greptile |
| gem "react_on_rails", "16.6.0.rc.0" | ||
| gem "shakapacker", "10.0.0.rc.0" |
There was a problem hiding this comment.
Build is broken per the PR description
The PR description's own build output shows a hard error that prevents the app from functioning:
ERROR in ./client/app/packs/server-bundle.js 4:1-52
× Module not found: Can't resolve './../generated/server-bundle-generated.js'
The server-bundle-generated.js file, which is expected to be produced by the react_on_rails:generate_packs rake task, is missing. The upgrade to react_on_rails 16.6.0.rc.0 / shakapacker 10.0.0.rc.0 appears to require this generated artefact, and it hasn't been committed or regenerated here. Merging this as-is will leave the repo in a broken state for anyone who pulls master.
|
|
||
| gem "react_on_rails", "16.4.0" | ||
| gem "shakapacker", "9.7.0" | ||
| gem "react_on_rails", "16.6.0.rc.0" |
There was a problem hiding this comment.
Pinning to an RC version on the main branch is risky if this gem is used as a dependency reference by downstream projects. Consider whether this should live on a dedicated rc-testing branch until both gems reach stable release, or at minimum add a comment explaining the temporary nature of this pin.
| gem "react_on_rails", "16.4.0" | ||
| gem "shakapacker", "9.7.0" | ||
| gem "react_on_rails", "16.6.0.rc.0" | ||
| gem "shakapacker", "10.0.0.rc.0" |
There was a problem hiding this comment.
Major version bump (9 → 10). Shakapacker 10.x may include breaking changes beyond just the version pin. The PR includes no code changes to configuration files (e.g. shakapacker.yml, webpack config) — please confirm that no configuration schema changes are required for v10, or link to the shakapacker migration guide.
| "react-dom": "^19.0.0", | ||
| "react-intl": "^6.4.4", | ||
| "react-on-rails": "16.4.0", | ||
| "react-on-rails": "16.6.0-rc.0", |
There was a problem hiding this comment.
The rescript-react-on-rails package (line ~92) is still pinned to 1.1.0. Please verify it is compatible with react-on-rails@16.6.0-rc.0 — a major or minor version gap here can cause runtime issues with ReScript bindings.
Review: Upgrade React on Rails and ShakaPacker to RC buildsSummaryThe diff itself is clean — only the four manifest files are touched with no unrelated churn. Version format is correctly handled ( That said, there are a few things worth resolving before merging: 🔴 Known broken build (blocker)The PR description explicitly states:
Merging with a known-broken test build means CI cannot validate the upgrade and any regression would be invisible. Options:
🟡 RC versions on the default branchPinning RC versions on
Consider whether a short-lived 🟡 Shakapacker major version bump (9 → 10)No webpack/shakapacker configuration files were changed. Please confirm:
✅ What looks good
|
|
✅ Review app for PR #710 was successfully deleted |
Bumps React on Rails and ShakaPacker to the newly published RC versions in both Ruby and npm manifests.
Updates Gemfile.lock and yarn.lock to the matching resolved RC packages only, with no unrelated dependency churn.
Validation included Ruby and Yarn version checks, and
yarn build:testcurrently fails in this repo becauseclient/app/generated/server-bundle-generated.jsis missing.Summary by CodeRabbit