[chore] add passthrough query as a tablefactor#32
Merged
ayman-sigma merged 1 commit intomainfrom Apr 10, 2025
Merged
Conversation
jmhain
approved these changes
Apr 9, 2025
Author
|
hmmm, I can't get the same clippy errors here when running locally. Which is very annoying... |
ayman-sigma
force-pushed
the
ayman/passThroughQuery
branch
from
2201d67 to
fce3ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to have the capability to specify subquery of a SQL string that we don't necessarily need to parse. This passthrough query will be only created at runtime and serialized as it is.
The main purpose here is performance and to avoid any potential parsing bugs with already known valid SQL.