fix: alloc(0) call is UB#442
Open
EmilyMatt wants to merge 5 commits intosimd-lite:mainfrom
Open
Conversation
Contributor
Author
|
@Licenser Does this have anything actionable for me? or is just pending due to time limitations? |
Contributor
Author
|
I'm fixing CI here(some clippy warnings and wastime installation) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 72.33% 72.16% -0.17%
==========================================
Files 51 49 -2
Lines 11435 11318 -117
==========================================
- Hits 8271 8168 -103
+ Misses 3164 3150 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 30, 2026
Contributor
Author
|
@Licenser Last two checks can't be green until merged to main (I think they will only be green in the next PRs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling alloc(), the layout must be non-zero, otherwise we fall into undefined behaviour.
This is documented in the function's docs:
https://doc.rust-lang.org/beta/src/core/alloc/global.rs.html#152
We can just make a dangling pointer for those cases, and not deallocate it
Found by running miri on tests::test_send_sync