Skip to content

fix(dialogs): standardized delete modals#2049

Merged
waleedlatif1 merged 6 commits intostagingfrom
fix/ui-dialog
Nov 19, 2025
Merged

fix(dialogs): standardized delete modals#2049
waleedlatif1 merged 6 commits intostagingfrom
fix/ui-dialog

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • standardized delete modals

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Nov 19, 2025 5:14am

… modal z-index (#2044)

* cleanup

* show trace spans for child blocks that error

* fix z index for cancel subscription popup

* rotating digit live usage indicator

* fix

* remove unused code

* fix type

* fix(billing): fix team upgrade

* fix

* fix tests

---------

Co-authored-by: waleed <walif6@gmail.com>
@waleedlatif1 waleedlatif1 marked this pull request as ready for review November 19, 2025 05:04
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Nov 19, 2025

Greptile Summary

  • Refactored all delete/confirmation modals from ui/alert-dialog and ui/dialog to standardized emcn Modal components
  • Removed unused workflow text editor components and associated barrel exports

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The changes are purely presentational refactoring, replacing UI components with standardized equivalents while maintaining identical functionality. No logic changes were introduced, and unused code was cleanly removed.
  • No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/components/create-chunk-modal/create-chunk-modal.tsx Refactored from Dialog/AlertDialog to Modal components from emcn, updated structure and styling to match new design system
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/components/edit-chunk-modal/edit-chunk-modal.tsx Refactored delete confirmation modal to use emcn Modal components, removed unnecessary comments, standardized styling
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-text-editor/workflow-text-editor-modal.tsx Removed unused workflow text editor modal component and its barrel export

Sequence Diagram

sequenceDiagram
    participant User
    participant Component
    participant Modal
    participant API
    
    User->>Component: Click delete/edit action
    Component->>Modal: Open Modal with form
    Modal->>User: Display modal content
    User->>Modal: Fill form and click action
    Modal->>API: Send request (create/update/delete)
    API->>Modal: Return response
    Modal->>Component: Close modal and trigger callback
    Component->>User: Update UI with changes
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

37 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@waleedlatif1 waleedlatif1 merged commit 7045c4a into staging Nov 19, 2025
4 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/ui-dialog branch November 19, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants