Skip to content

fix: terminal spacing, subflow disabled in preview #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emir-karabeg merged 2 commits into from
Jan 28, 2026
Merged

fix: terminal spacing, subflow disabled in preview #3055

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012945c
fix: terminal spacing, subflow disabled in preview
emir-karabeg Jan 28, 2026
32b4a26
addressed comments
emir-karabeg Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,10 @@ const ExecutionGroupRow = memo(function ExecutionGroupRow({
return (
<div className='flex flex-col px-[6px]'>
{/* Separator between executions */}
{showSeparator && <div className='mx-[4px] my-[4px] border-[var(--border)] border-t' />}
{showSeparator && <div className='mx-[4px] mb-[6px] border-[var(--border)] border-t' />}

{/* Entry tree */}
<div className='ml-[4px] flex flex-col gap-[2px] pb-[4px]'>
<div className='ml-[4px] flex flex-col gap-[2px] pb-[6px]'>
{group.entryTree.map((node) => (
<EntryNodeRow
key={node.entry.id}
Expand Down
25 changes: 22 additions & 3 deletions ...kspaceId]/w/components/preview/components/preview-workflow/components/subflow/subflow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import { memo } from 'react'
import { RepeatIcon, SplitIcon } from 'lucide-react'
import { Handle, type NodeProps, Position } from 'reactflow'
import { Badge } from '@/components/emcn'
import { cn } from '@/lib/core/utils/cn'
import { HANDLE_POSITIONS } from '@/lib/workflows/blocks/block-dimensions'

/** Execution status for subflows in preview mode */
Expand All @@ -13,6 +15,8 @@ interface WorkflowPreviewSubflowData {
width?: number
height?: number
kind: 'loop' | 'parallel'
/** Whether this subflow is enabled */
enabled?: boolean
/** Whether this subflow is selected in preview mode */
isPreviewSelected?: boolean
/** Execution status for highlighting the subflow container */
Expand All @@ -27,7 +31,15 @@ interface WorkflowPreviewSubflowData {
* or interactive features.
*/
function WorkflowPreviewSubflowInner({ data }: NodeProps<WorkflowPreviewSubflowData>) {
const { name, width = 500, height = 300, kind, isPreviewSelected = false, executionStatus } = data
const {
name,
width = 500,
height = 300,
kind,
enabled = true,
isPreviewSelected = false,
executionStatus,
} = data

const isLoop = kind === 'loop'
const BlockIcon = isLoop ? RepeatIcon : SplitIcon
Expand Down Expand Up @@ -84,14 +96,21 @@ function WorkflowPreviewSubflowInner({ data }: NodeProps<WorkflowPreviewSubflowD
<div className='flex min-w-0 flex-1 items-center gap-[10px]'>
<div
className='flex h-[24px] w-[24px] flex-shrink-0 items-center justify-center rounded-[6px]'
style={{ backgroundColor: blockIconBg }}
style={{ backgroundColor: enabled ? blockIconBg : 'gray' }}
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoded 'gray' violates styling rules - use CSS variable like var(--surface-4) or #808080

Suggested change
style={{ backgroundColor: enabled ? blockIconBg : 'gray' }}
style={{ backgroundColor: enabled ? blockIconBg : 'var(--surface-4)' }}

Context Used: Context from dashboard - Tailwind CSS and styling conventions (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI 
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/components/subflow/subflow.tsx
Line: 99:99

Comment:
hardcoded `'gray'` violates styling rules - use CSS variable like `var(--surface-4)` or `#808080`

```suggestion
            style={{ backgroundColor: enabled ? blockIconBg : 'var(--surface-4)' }}
```

**Context Used:** Context from `dashboard` - Tailwind CSS and styling conventions ([source](https://app.greptile.com/review/custom-context?memory=e1e9ca56-9819-463f-be67-0d2ba849ec4f))

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

>
<BlockIcon className='h-[16px] w-[16px] text-white' />
</div>
<span className='font-medium text-[16px]' title={blockName}>
<span
className={cn(
'truncate font-medium text-[16px]',
!enabled && 'text-[var(--text-muted)]'
)}
title={blockName}
>
{blockName}
</span>
</div>
{!enabled && <Badge variant='gray-secondary'>disabled</Badge>}
</div>

{/* Content area - matches workflow structure */}
Expand Down
1 change: 1 addition & 0 deletions ...space/[workspaceId]/w/components/preview/components/preview-workflow/preview-workflow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ export function PreviewWorkflow({
width: dimensions.width,
height: dimensions.height,
kind: block.type as 'loop' | 'parallel',
enabled: block.enabled ?? true,
isPreviewSelected: isSelected,
executionStatus: subflowExecutionStatus,
lightweight,
Expand Down