Skip to content

improvement(timeouts): files/base64 should use max timeouts + auth centralization #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 8 commits into from
Feb 10, 2026
Merged

improvement(timeouts): files/base64 should use max timeouts + auth centralization #3179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8902752
improvement(timeouts): files/base64 should use max timeouts
icecrasher321 Feb 10, 2026
0ff7e57
fix(billing): attribute cost to caller when info available"
icecrasher321 Feb 10, 2026
908f7ea
remove owner reference in billing
icecrasher321 Feb 10, 2026
b9171fa
fix auth
icecrasher321 Feb 10, 2026
c0b7ec0
update tests
icecrasher321 Feb 10, 2026
b7aa96c
fix return code
icecrasher321 Feb 10, 2026
c4d51ef
use shared types
icecrasher321 Feb 10, 2026
ab695c8
fix bugbot comment
icecrasher321 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/sim/app/api/jobs/[jobId]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export async function GET(
}

if (job.status === JOB_STATUS.PROCESSING || job.status === JOB_STATUS.PENDING) {
response.estimatedDuration = 180000
response.estimatedDuration = 300000
}

return NextResponse.json(response)
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/lib/knowledge/documents/document-processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { mistralParserTool } from '@/tools/mistral/parser'
const logger = createLogger('DocumentProcessor')

const TIMEOUTS = {
FILE_DOWNLOAD: 180000,
FILE_DOWNLOAD: 600000,
MISTRAL_OCR_API: 120000,
} as const

Expand Down
6 changes: 5 additions & 1 deletion apps/sim/lib/uploads/utils/file-utils.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use server'

import type { Logger } from '@sim/logger'
import { getMaxExecutionTimeout } from '@/lib/core/execution-limits'
import {
secureFetchWithPinnedIP,
validateUrlWithDNS,
Expand Down Expand Up @@ -135,7 +136,10 @@ export async function resolveFileInputToUrl(
* For internal URLs, uses direct storage access (server-side only)
* For external URLs, validates DNS/SSRF and uses secure fetch with IP pinning
*/
export async function downloadFileFromUrl(fileUrl: string, timeoutMs = 180000): Promise<Buffer> {
export async function downloadFileFromUrl(
fileUrl: string,
timeoutMs = getMaxExecutionTimeout()
): Promise<Buffer> {
const { parseInternalFileUrl } = await import('./file-utils')

if (isInternalFileUrl(fileUrl)) {
Expand Down
3 changes: 2 additions & 1 deletion apps/sim/lib/uploads/utils/user-file-base64.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import type { Logger } from '@sim/logger'
import { createLogger } from '@sim/logger'
import { getRedisClient } from '@/lib/core/config/redis'
import { getMaxExecutionTimeout } from '@/lib/core/execution-limits'
import { isUserFileWithMetadata } from '@/lib/core/utils/user-file'
import { bufferToBase64 } from '@/lib/uploads/utils/file-utils'
import { downloadFileFromStorage, downloadFileFromUrl } from '@/lib/uploads/utils/file-utils.server'
import type { UserFile } from '@/executor/types'

const DEFAULT_MAX_BASE64_BYTES = 10 * 1024 * 1024
const DEFAULT_TIMEOUT_MS = 180000
const DEFAULT_TIMEOUT_MS = getMaxExecutionTimeout()
const DEFAULT_CACHE_TTL_SECONDS = 300
const REDIS_KEY_PREFIX = 'user-file:base64:'

Expand Down