-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: emcn component library design engineering polish #3672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
eec6a82
chore: fix conflicts
adithyaakrishna 3f0a02c
chore: fix conflicts
adithyaakrishna 629f8ab
chore: pause marquee
adithyaakrishna e64b73e
chore: fix conflicts
adithyaakrishna 7e8f18e
chore: fix conflicts
adithyaakrishna 739522d
chore: address review comments
adithyaakrishna c5cdf64
chore: fix conflicts
adithyaakrishna ba7d9cf
chore: other bug fixes
adithyaakrishna ad4285c
chore: fix conflicts
adithyaakrishna e951161
chore: fix radius
adithyaakrishna e20c084
chore: fix review changes
adithyaakrishna acc8e86
chore: fix conflicts
adithyaakrishna 34bb996
chore: revert other
adithyaakrishna 6d389ff
chore: fix conflicts
adithyaakrishna fad5bde
chore: fix review changes
adithyaakrishna 3eb3f0c
chore: fix conflicts
adithyaakrishna 1c44d4d
chore: fix review changes
adithyaakrishna 1d72815
chore: fix button state
adithyaakrishna 0596d43
chore: fix button state
adithyaakrishna 54c2765
chore: fix review changes
adithyaakrishna 5d71226
chore: fix lint
adithyaakrishna 494e269
chore: fix conflicts
adithyaakrishna 13f0d2c
chore: add metadata
adithyaakrishna ef95212
chore: fix things
adithyaakrishna 6642257
chore: fix overwritten states
adithyaakrishna 2123998
chore: fix warnings
adithyaakrishna 956b629
chore: fix button state
adithyaakrishna 351d20a
chore: fix review changes
adithyaakrishna 7b3a378
chore: fix review changes
adithyaakrishna bfcaeb3
chore: fix hover state
adithyaakrishna b9cdaf9
chore: fix popover
adithyaakrishna c8feace
chore: fix review changes
adithyaakrishna 2715ffb
chore: fix review changes
adithyaakrishna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.