fix: upgrade HashString from SHA1 to SHA-256#522
Merged
Conversation
SHA1 is flagged by Snyk as a weak hash algorithm. HashString is used only for PII anonymization in diagnostics, so upgrading to SHA-256 is safe with no external compatibility concerns.
mwbrooks
added
security
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 71.26% 71.23% -0.03%
==========================================
Files 222 222
Lines 18682 18682
==========================================
- Hits 13314 13309 -5
- Misses 4188 4191 +3
- Partials 1180 1182 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks @zimeg! |
Contributor
|
Nice ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request upgrades the
HashStringfunction ininternal/goutils/strings.gofrom SHA1 to SHA-256 to resolve a Snyk code analysis finding for use of a weak hash algorithm.HashStringis used only to anonymize PII (e.g. system hostname) in diagnostic data. No external system depends on the hash format, so the upgrade is safe.Preview
Requirements