feat: Add support for lubridate::month()#660
Open
andreranza wants to merge 16 commits intotidyverse:mainfrom
Open
feat: Add support for lubridate::month()#660andreranza wants to merge 16 commits intotidyverse:mainfrom
lubridate::month()#660andreranza wants to merge 16 commits intotidyverse:mainfrom
Conversation
Contributor
Author
|
After #658. |
Member
|
Thanks!
|
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0f1854f is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Contributor
Author
|
Right. The contribution guide mentions that. Will add tests, too. |
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if c346fb5 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Contributor
Author
|
Thanks, @krlmlr. I added one test and updated the vignette. Is this good enough? Am I missing something? |
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if f523905 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Member
|
Thanks. Tests failed with the last run, let's see. What about |
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 07d4258 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Contributor
Author
|
Thank you, @krlmlr.
|
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8fb1f55 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Contributor
Author
|
Still failing: Didn't get it running tests locally, IIRC. Do I need |
Member
|
Yes, we need |
…th' into f-167-lubridate-month
Contributor
Author
|
Seeing some type mismatch using |
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 212f8b5 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if e23796d is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for lubridate::month() and several other lubridate date manipulation functions to duckplyr. The changes enable these functions to be translated and executed efficiently in DuckDB.
Changes:
- Added
lubridate::month()to the list of implemented date manipulation functions in documentation - Extended translation support for multiple lubridate functions including
day(),month(),year(),quarter(), and various date parsing functions - Added comprehensive test coverage for the new lubridate functions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vignettes/limits.Rmd | Updated documentation to include lubridate::month() in the list of implemented functions and added it to the example code |
| tools/00-funs.R | Added test cases for new lubridate functions including day(), month(), year(), and date parsing functions |
| tests/testthat/test-as_duckplyr_df.R | Added test cases verifying correct behavior of lubridate functions (day(), month(), year(), quarter(), ymd()) |
| R/translate.R | Registered multiple lubridate functions in the package lookup table for translation support |
Comments suppressed due to low confidence (2)
vignettes/limits.Rmd:199
- Trailing whitespace detected on lines 197-199. Remove the trailing spaces after the commas for consistency with line 200.
hour = lubridate::hour(a),
minute = lubridate::minute(a),
second = lubridate::second(a),
tests/testthat/test-as_duckplyr_df.R:1675
- Extra blank line found between test blocks. Remove one blank line to maintain consistency with spacing between other test cases in this file.
test_that("as_duckplyr_df_impl() and mutate(d = lubridate::year(d))", {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9570cb5 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167.