fix(rsc): fix false detection of import.meta.viteRsc API inside comments and strings#938
Merged
fix(rsc): fix false detection of import.meta.viteRsc API inside comments and strings#938
import.meta.viteRsc API inside comments and strings#938Conversation
…nts and strings Co-authored-by: hi-ogawa <4232207+hi-ogawa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues in pull request #931 for vite-plugin-react
fix(rsc): fix false detection of Oct 22, 2025
import.meta.viteRsc API inside comments and strings
Co-authored-by: hi-ogawa <4232207+hi-ogawa@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strip-literaldependency to packages/plugin-rsc/package.jsonstripLiteralfunction in packages/plugin-rsc/src/plugin.tsstripLiteral()to code before matchAll forimport.meta.viteRsc.loadModulestripLiteral()to code before matchAll forimport.meta.viteRsc.loadBootstrapScriptContentstripLiteral()to code before matchAll forimport.meta.viteRsc.loadCssSummary
Fixed false detection of
import.meta.viteRscAPI calls inside comments and strings by:strip-literal@^3.1.0dependency to strip comments and string literals before pattern matchingstripLiteral(code).matchAll()instead ofcode.matchAll()The fix ensures that API calls in comments like
// import.meta.viteRsc.loadModule("test")and strings like"import.meta.viteRsc.loadCss('test')"are correctly ignored, while actual API calls are properly detected and transformed.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.