Check if url functions are supported in attr() security tests#59188
Open
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Open
Check if url functions are supported in attr() security tests#59188chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
Blink, as well as Gecko and Webkit do not support src() function [0] and image() function [1]. Hypothetical string() function is not supported as well. This causes some of the attr() security tests to incorrectly fail. If function is not supported this should not be a violation to the security, so we can just skip these tests. This Cl also restructures test a bit, use consts instead of long urls. [0] https://drafts.csswg.org/css-values-4/#urls [1] https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/image/image Fixed: 489670248 Change-Id: I7fe76e02135d983c4f2f801d63a28eee7cb992d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7748788 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1614350}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7748788
branch
from
5e9fedd to
f5bd9aa
Compare
wpt-pr-bot
approved these changes
Apr 14, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blink, as well as Gecko and Webkit do not support src() function [0]
and image() function [1]. Hypothetical string() function is not
supported as well. This causes some of the attr() security tests to
incorrectly fail. If function is not supported this should not be a
violation to the security, so we can just skip these tests.
This Cl also restructures test a bit, use consts instead of long urls.
[0] https://drafts.csswg.org/css-values-4/#urls
[1] https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Values/image/image
Fixed: 489670248
Change-Id: I7fe76e02135d983c4f2f801d63a28eee7cb992d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7748788
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Munira Tursunova <moonira@google.com>
Cr-Commit-Position: refs/heads/main@{#1614350}