fix: do not call the next middleware for 304 response#2155
Merged
alexander-akait merged 1 commit intomasterfrom Sep 2, 2025
Merged
fix: do not call the next middleware for 304 response#2155alexander-akait merged 1 commit intomasterfrom
alexander-akait merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2155 +/- ##
==========================================
+ Coverage 96.29% 96.30% +0.01%
==========================================
Files 13 13
Lines 890 893 +3
Branches 265 266 +1
==========================================
+ Hits 857 860 +3
Misses 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes - webpack/webpack-dev-server#5519
Breaking Changes
Mostly no, potentially some application allow to change status code and remove headers, but webpack-dev-middleware should be the last point in middlewares, so this change fixes bugs when other middleware is trying to write headers/body
Additional Info
Inspired by - https://github.com/pillarjs/send/blob/master/index.js#L273