refactor: logic for cacheImmutable#2254
Merged
alexander-akait merged 1 commit intonextfrom Jan 27, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #2254 +/- ##
=======================================
Coverage 95.84% 95.85%
=======================================
Files 13 13
Lines 891 892 +1
Branches 260 260
=======================================
+ Hits 854 855 +1
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexander-akait
commented
Jan 27, 2026
| if (cacheControl.immutable) { | ||
| cacheControlValue += ", immutable"; | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Refactor logic:
- based on type (boolean, number, string or object) we will write header value directly into
cacheControlValue cacheImmutablealways takes preference- if you set
cacheControl: { immutable: true }we will always write, immutableevencacheImmutableisfalse
alexander-akait
commented
Jan 27, 2026
| }); | ||
|
|
||
| describe("should use cacheControl object option (with only immutable: true) when cacheImmutable is false, and not add 'immutable' to Cache-Control header", () => { | ||
| describe("should use cacheControl object option (with only immutable: true) when cacheImmutable is false, and add 'immutable' to Cache-Control header", () => { |
Member
Author
There was a problem hiding this comment.
We should always write , immutable even if cacheControl is false, developers literally indicated that everything is immutable
alexander-akait
added a commit
that referenced
this pull request
Mar 11, 2026
alexander-akait
added a commit
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refactor logic for #2247
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing