-
-
Notifications
You must be signed in to change notification settings - Fork 382
feat: add forwardError option to enable error forwarding to next middleware
#2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
29335cb
feat: add `forwardError` option to enable error forwarding to next mi…
bjohansebas a813442
feat: add error middleware support in frameworkFactory for improved e…
bjohansebas ef885d0
feat: enhance error handling by removing response headers before forw…
bjohansebas 67e67c1
feat: remove error middleware option from frameworkFactory for cleane…
bjohansebas afe1f82
test: update middleware tests to reflect changes in error handling wi…
bjohansebas 441a9ca
test: update middleware tests to handle error forwarding for hapi fra…
bjohansebas ba17cf0
feat: implement error forwarding in koa middleware and update tests a…
bjohansebas 215a71c
feat: add error forwarding support in hono middleware and update test…
bjohansebas 829ba0d
feat: add forwardError option to README with usage example
bjohansebas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -172,6 +172,11 @@ | |
| "description": "Enable or disable setting `Cache-Control: public, max-age=31536000, immutable` response header for immutable assets (i.e. asset with a hash in file name like `image.a4c12bde.jpg`).", | ||
| "link": "https://github.com/webpack/webpack-dev-middleware#cacheimmutable", | ||
| "type": "boolean" | ||
| }, | ||
| "forwardError": { | ||
| "description": "Enable or disable forwarding errors to next middleware.", | ||
| "link": "https://github.com/webpack/webpack-dev-middleware#forwarderrors", | ||
| "type": "boolean" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add this to our README too
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yep! |
||
| } | ||
| }, | ||
| "additionalProperties": false | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.