Skip to content

feat: next#2284

Merged
alexander-akait merged 30 commits intomainfrom
next
Mar 18, 2026
Merged

feat: next#2284
alexander-akait merged 30 commits intomainfrom
next

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

Summary

No squash when merging

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

bjohansebas and others added 9 commits March 11, 2026 16:08
* feat: enable cacheImmutable by default

* fix: thoses files shouldn't immutable

* fix: update cache control logic

becauses undefined !== false (true)

* test: add tests for cacheControl option behavior with cacheImmutable set to false

* refactor: normalize cacheControl handling in response headers

* refactor: simplify maxAge calculation in cacheControl handling
…ddleware (#2259)

* feat: add `forwardError` option to enable error forwarding to next middleware

* feat: add error middleware support in frameworkFactory for improved error handling

* feat: enhance error handling by removing response headers before forwarding errors

* feat: remove error middleware option from frameworkFactory for cleaner middleware setup

* test: update middleware tests to reflect changes in error handling with forwardError option

* test: update middleware tests to handle error forwarding for hapi framework

* feat: implement error forwarding in koa middleware and update tests accordingly

* feat: add error forwarding support in hono middleware and update tests accordingly

* feat: add forwardError option to README with usage example
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 95.11002% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.11%. Comparing base (1169465) to head (060bb9a).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
src/index.js 93.18% 12 Missing ⚠️
src/middleware.js 95.48% 6 Missing ⚠️
src/utils.js 98.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
+ Coverage   95.88%   96.11%   +0.22%     
==========================================
  Files          13        3      -10     
  Lines         900      900              
  Branches      270      266       -4     
==========================================
+ Hits          863      865       +2     
+ Misses         37       35       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait
Copy link
Copy Markdown
Member Author

Sometimes hono is unstable when writeToDisk: true with TypeError: Invalid state: ReadableStream is already closed, investigating

@alexander-akait
Copy link
Copy Markdown
Member Author

alexander-akait commented Mar 12, 2026

@bjohansebas I will make a webpack-cli release and focus on it, there are three things left:

I will take care about them, so you can focus on webpack-dev-server more

@bjohansebas
Copy link
Copy Markdown
Member

Okay, but for compile.validate, we need webpack to release that support. The PR was already merged in webpack, but it’s not officially published on npm yet, so it can’t be updated yet to include that support

@alexander-akait
Copy link
Copy Markdown
Member Author

@bjohansebas Yeah, I just want to add this check for future

@alexander-akait
Copy link
Copy Markdown
Member Author

Looks like known issue - honojs/node-server#233

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: 060bb9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack-dev-middleware Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexander-akait alexander-akait merged commit 08067f3 into main Mar 18, 2026
42 of 44 checks passed
@alexander-akait alexander-akait deleted the next branch March 18, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants