Add missing include in asn.h#10014
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Mar 19, 2026
Merged
Conversation
dgarske
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build fragility in wolfssl/wolfcrypt/asn.h by adding a direct include for sha512.h when SHA-384 or SHA-512 is enabled, avoiding reliance on transitive include order.
Changes:
- Add conditional inclusion of
wolfssl/wolfcrypt/sha512.hunderWOLFSSL_SHA384orWOLFSSL_SHA512.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
|
Merged early |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/asn.h uses WC_SHA384_DIGEST_SIZE and WC_SHA512_DIGEST_SIZE, but did not include wolfssl/wolfcrypt/sha512.h directly. This relied on transitive include order and broke builds where asn.h is parsed before hash.h/sha512.h, such as hash.c with SHA-384 enabled.
Regression introduced in #9761