Skip to content

SP non-block ECC: correct mont_inv_order #10044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 1 commit into from
Mar 23, 2026
Merged

SP non-block ECC: correct mont_inv_order #10044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_arm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79156,7 +79156,7 @@ static int sp_256_mont_inv_order_8_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_256_mont_mul_order_8(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 8U);
Expand Down Expand Up @@ -97352,7 +97352,7 @@ static int sp_384_mont_inv_order_12_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const
sp_384_mont_mul_order_12(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 12U);
Expand Down Expand Up @@ -125751,7 +125751,7 @@ static int sp_521_mont_inv_order_17_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const
sp_521_mont_mul_order_17(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 17U);
Expand Down
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_arm64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40410,7 +40410,7 @@ static int sp_256_mont_inv_order_4_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_256_mont_mul_order_4(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 4U);
Expand Down Expand Up @@ -66248,7 +66248,7 @@ static int sp_384_mont_inv_order_6_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_384_mont_mul_order_6(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 6U);
Expand Down Expand Up @@ -110714,7 +110714,7 @@ static int sp_521_mont_inv_order_9_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_521_mont_mul_order_9(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 9U);
Expand Down
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_armthumb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104906,7 +104906,7 @@ static int sp_256_mont_inv_order_8_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_256_mont_mul_order_8(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 8U);
Expand Down Expand Up @@ -115433,7 +115433,7 @@ static int sp_384_mont_inv_order_12_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const
sp_384_mont_mul_order_12(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 12U);
Expand Down Expand Up @@ -130970,7 +130970,7 @@ static int sp_521_mont_inv_order_17_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const
sp_521_mont_mul_order_17(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 17U);
Expand Down
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_c32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23764,7 +23764,7 @@ static int sp_256_mont_inv_order_9_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_256_mont_mul_order_9(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 9U);
Expand Down Expand Up @@ -31437,7 +31437,7 @@ static int sp_384_mont_inv_order_15_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const
sp_384_mont_mul_order_15(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 15U);
Expand Down Expand Up @@ -39151,7 +39151,7 @@ static int sp_521_mont_inv_order_21_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const
sp_521_mont_mul_order_21(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 21U);
Expand Down
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_c64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24243,7 +24243,7 @@ static int sp_256_mont_inv_order_5_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_256_mont_mul_order_5(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 5U);
Expand Down Expand Up @@ -31307,7 +31307,7 @@ static int sp_384_mont_inv_order_7_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_384_mont_mul_order_7(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 7U);
Expand Down Expand Up @@ -38335,7 +38335,7 @@ static int sp_521_mont_inv_order_9_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_521_mont_mul_order_9(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 9U);
Expand Down
6 changes: 3 additions & 3 deletions wolfcrypt/src/sp_cortexm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40196,7 +40196,7 @@ static int sp_256_mont_inv_order_8_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_256_mont_mul_order_8(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 8U);
Expand Down Expand Up @@ -50204,7 +50204,7 @@ static int sp_384_mont_inv_order_12_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const
sp_384_mont_mul_order_12(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 12U);
Expand Down Expand Up @@ -63152,7 +63152,7 @@ static int sp_521_mont_inv_order_17_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const
sp_521_mont_mul_order_17(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 17U);
Expand Down
12 changes: 6 additions & 6 deletions wolfcrypt/src/sp_x86_64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24382,7 +24382,7 @@ static int sp_256_mont_inv_order_4_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_256_mont_mul_order_4(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 4U);
Expand Down Expand Up @@ -24605,7 +24605,7 @@ static int sp_256_mont_inv_order_avx2_4_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, co
sp_256_mont_mul_order_avx2_4(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 4U);
Expand Down Expand Up @@ -48945,7 +48945,7 @@ static int sp_384_mont_inv_order_6_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_384_mont_mul_order_6(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 6U);
Expand Down Expand Up @@ -49101,7 +49101,7 @@ static int sp_384_mont_inv_order_avx2_6_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, co
sp_384_mont_mul_order_avx2_6(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 6U);
Expand Down Expand Up @@ -89615,7 +89615,7 @@ static int sp_521_mont_inv_order_9_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, const s
sp_521_mont_mul_order_9(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 9U);
Expand Down Expand Up @@ -89784,7 +89784,7 @@ static int sp_521_mont_inv_order_avx2_9_nb(sp_ecc_ctx_t* sp_ctx, sp_digit* r, co
sp_521_mont_mul_order_avx2_9(t, t, a);
}
ctx->i--;
ctx->state = (ctx->i == 0) ? 3 : 1;
ctx->state = (ctx->i >= 0) ? 1 : 3;
break;
case 3:
XMEMCPY(r, t, sizeof(sp_digit) * 9U);
Expand Down
Loading