Ensure certificates are getting into cert manager#10073
Merged
dgarske merged 6 commits intowolfSSL:masterfrom Apr 29, 2026
Merged
Ensure certificates are getting into cert manager#10073dgarske merged 6 commits intowolfSSL:masterfrom
dgarske merged 6 commits intowolfSSL:masterfrom
Conversation
Member
Author
|
This replaces #8708 |
Before this fix, the certificates were not getting into the certificate manager. This makes sure they are going in.
dgarske
requested changes
Apr 9, 2026
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: REQUEST_CHANGES
Findings: 3 total — 3 posted, 1 skipped
Posted findings
- [Critical] test_X509_STORE_InvalidCa_NoCallback removed from .c but still declared and referenced in .h — linker error —
tests/api/test_ossl_x509_str.h:34,56 - [Medium] Defense-in-depth assertion removed from test_X509_STORE_InvalidCa without explanation —
tests/api/test_ossl_x509_str.c:1076-1077 - [Medium] Return value of X509StorePushCertsToCM silently ignored —
src/ssl_api_cert.c:1545
Skipped findings
- [Critical] test_X509_STORE_InvalidCa_NoCallback removed from .c but still declared and referenced in .h — linker error
Review generated by Skoll via openclaw
|
Member
Author
|
jenkins retest this please. |
dgarske
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ZD 19760